clear up props registry in shared backend on js thread (#56677)#56677
Closed
zeyap wants to merge 1 commit into
Closed
clear up props registry in shared backend on js thread (#56677)#56677zeyap wants to merge 1 commit into
zeyap wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103752709. |
meta-codesync
Bot
changed the title
zeyap
force-pushed
the
export-D103752709
branch
9 times, most recently
from
141377d to
38efda2
Compare
Summary: ## Changelog: [Internal] [Fixed] - clear up props registry in shared backend on js thread stopSurface is usually called from main thread, but `animatedPropsRegistry_->getMap` in animationBackendCommitHook is called from js thread. Removing the surface props entry on ui thread can cause race condition (getMap() result on js thread becomes undefined) https://www.internalfb.com/code/fbsource/[26d70084020e]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.cpp?lines=26-31 Reviewed By: christophpurrer Differential Revision: D103752709
|
This pull request has been merged in 0d20210. |
Collaborator
|
This pull request was successfully merged by @zeyap in 0d20210 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] [Fixed] - clear up props registry in shared backend on js thread
stopSurface is usually called from main thread, but
animatedPropsRegistry_->getMapin animationBackendCommitHook is called from js thread. Removing the surface props entry on ui thread can cause race condition (getMap() result on js thread becomes undefined)https://www.internalfb.com/code/fbsource/[26d70084020e]/xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.cpp?lines=26-31
Reviewed By: christophpurrer
Differential Revision: D103752709