remove reactDOM.findDOMNode usage#79
Open
joshbalfour wants to merge 1 commit intoreact-native-web-community:masterfrom
Open
remove reactDOM.findDOMNode usage#79joshbalfour wants to merge 1 commit intoreact-native-web-community:masterfrom
joshbalfour wants to merge 1 commit intoreact-native-web-community:masterfrom
Conversation
|
Any plans on releasing this? I am getting a |
mlazari
approved these changes
Jul 28, 2025
mlazari
left a comment
mlazari
left a comment
There was a problem hiding this comment.
LGTM, the only thing I would change is to move the createRef import to the first line:
import React, { createRef, PureComponent } from 'react';
xlecunff-pass
approved these changes
Aug 4, 2025
xlecunff-pass
left a comment
xlecunff-pass
left a comment
There was a problem hiding this comment.
LGTM but the library seems to be dead :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 19 removed ReactDOM.findDOMNode: https://18.react.dev/reference/react-dom/findDOMNode
This update follows their recommended alternative method.