Skip to content

fix: popup container scroll due to precision #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 2 commits into from
Jan 12, 2026
+6 −6
Merged

fix: popup container scroll due to precision #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
343f433
fix: popup container scroll due to precision
aojunhao123 Jan 10, 2026
d80e240
chore: adjust
aojunhao123 Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/hooks/useAlign.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,13 +698,13 @@ export default function useAlign(
popupMirrorRect.bottom - popupRect.y - (nextOffsetY + popupRect.height);

if (scaleX === 1) {
nextOffsetX = Math.round(nextOffsetX);
offsetX4Right = Math.round(offsetX4Right);
nextOffsetX = Math.floor(nextOffsetX);
offsetX4Right = Math.floor(offsetX4Right);
Comment on lines -701 to +702
Copy link
Contributor Author

@aojunhao123 aojunhao123 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

round改为floor我理解没什么副作用，唯一的弊端可能就是精度差异会变大，原来最多0.5px的差异，现在最大精度差可能为0.99px，但用户真能感知到吗（

}

if (scaleY === 1) {
nextOffsetY = Math.round(nextOffsetY);
offsetY4Bottom = Math.round(offsetY4Bottom);
nextOffsetY = Math.floor(nextOffsetY);
offsetY4Bottom = Math.floor(offsetY4Bottom);
}

const nextOffsetInfo = {
Expand Down
4 changes: 2 additions & 2 deletions tests/align.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ describe('Trigger.Align', () => {
});
});

it('round when decimal precision', async () => {
it('floor when decimal precision', async () => {
rectX = 22.6;
rectY = 33.4;
rectWidth = 33.7;
Expand All @@ -293,7 +293,7 @@ describe('Trigger.Align', () => {
await awaitFakeTimer();

expect(document.querySelector('.rc-trigger-popup')).toHaveStyle({
top: `56px`,
top: `55px`,
});
});

Expand Down
Loading