Skip to content

migrate to @rc-component/virtual-list #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afc163 merged 2 commits into from
Dec 2, 2025
+6 −6
Merged

migrate to @rc-component/virtual-list #1423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b25b057
migrate to @rc-component/virtual-list
yoyo837 Dec 1, 2025
d6f8b18
Apply suggestion from @yoyo837
yoyo837 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
"@rc-component/context": "^2.0.1",
"@rc-component/resize-observer": "^1.0.0",
"@rc-component/util": "^1.1.0",
"clsx": "^2.1.1",
"rc-virtual-list": "^3.14.2"
"@rc-component/virtual-list": "^1.0.1",
"clsx": "^2.1.1"
},
"devDependencies": {
"@rc-component/father-plugin": "^2.0.1",
Expand Down
4 changes: 2 additions & 2 deletions src/VirtualTable/BodyGrid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useContext } from '@rc-component/context';
import VirtualList, { type ListProps, type ListRef } from 'rc-virtual-list';
import VirtualList, { type ListProps, type ListRef } from '@rc-component/virtual-list';
import * as React from 'react';
import TableContext, { responseImmutable } from '../context/TableContext';
import useFlattenRecords, { type FlattenData } from '../hooks/useFlattenRecords';
Expand Down Expand Up @@ -224,7 +224,7 @@ const Grid = React.forwardRef<GridRef, GridProps>((props, ref) => {
// ========================== Render ==========================
const tblPrefixCls = `${prefixCls}-tbody`;

// default 'div' in rc-virtual-list
// default 'div' in @rc-component/virtual-list
const wrapperComponent = getComponent(['body', 'wrapper']);

// ========================== Sticky Scroll Bar ==========================
Expand Down
4 changes: 2 additions & 2 deletions tests/Virtual.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ const identity = (value: any) => value;
global.scrollToConfig = null;
global.collectGetScrollInfoReturn = identity;

vi.mock('rc-virtual-list', async () => {
const RealVirtualList = ((await vi.importActual('rc-virtual-list')) as any).default;
vi.mock('@rc-component/virtual-list', async () => {
const RealVirtualList = ((await vi.importActual('@rc-component/virtual-list')) as any).default;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve type safety and avoid using as any, you can use a dynamic import for the type with vi.importActual. This will provide proper typing for RealVirtualList and make the test mock more robust.

Suggested change
const RealVirtualList = ((await vi.importActual('@rc-component/virtual-list')) as any).default;
const { default: RealVirtualList } = await vi.importActual<typeof import('@rc-component/virtual-list')>('@rc-component/virtual-list');


const WrapperVirtualList = React.forwardRef((props: any, ref) => {
const myRef = React.useRef(null);
Expand Down