Refactor Project Api#1531
Merged
jochenklar merged 11 commits into3.0.0/releasefrom Mar 1, 2026
Merged
Conversation
CalamityC
approved these changes
Feb 26, 2026
Member
Author
|
Hi @CalamityC, I added a few more changes after our meeting:
|
CalamityC
requested changes
Feb 27, 2026
Member
Author
|
|
CalamityC
reviewed
Feb 27, 2026
| parent = ParentField(required=False, allow_null=True) | ||
| parent_title = serializers.CharField(source='parent.title', read_only=True) | ||
|
|
||
| owners = ProjectUserSerializer(many=True, read_only=True) |
Collaborator
There was a problem hiding this comment.
I think we need that too, or how do we get the owner of a project in projects list (it's supposed to be displayed in the table)?
ATM we use it here:
Member
Author
There was a problem hiding this comment.
Yes, I forgot about this. I added them again. But now with more database magic ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a subquery for highest role in the hierarchy and refactors
ProjectSerializerto include the label ofcurrent_roleandhighest_roleand adds project information for the latter, e.g.: