RDKEMW-12334-The log entries in remote-debugger.log #171
Conversation
RDKEMW-12334-The log entries in remote-debugger.log differ between C binary files and script files when compared
Code Coverage Summary |
Code Coverage Summary |
There was a problem hiding this comment.
Pull request overview
This pull request updates log entries in the remote-debugger.log file to match the format and content of the original shell script implementation. The changes improve logging consistency and add proper Apache 2.0 licensing to the uploadRRDLogs.c file.
Changes:
- Updated copyright header in uploadRRDLogs.c from skeleton comment to proper Apache 2.0 license
- Modified log messages throughout the upload orchestration flow to match the original shell script format
- Changed log level from DEBUG to INFO for archive filename generation in rrd_archive.c
- Added MAC address setup to L2 test script for improved test coverage
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/uploadRRDLogs.c | Updated copyright header and revised log messages to match shell script format, improving traceability and consistency |
| src/rrd_archive.c | Changed filename generation log from DEBUG to INFO level for better visibility |
| run_l2.sh | Added MAC address to test environment for L2 testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| mkdir -p /media/apps/RDK-RRD-Test/etc/rrd | ||
|
|
||
| touch /media/apps/RDK-RRD-Test/etc/rrd/remote_debugger.json | ||
| echo "AA:BB:CC:dd:EE:FF" >> /tmp/.estb_mac |
There was a problem hiding this comment.
The MAC address format "AA:BB:CC:dd:EE:FF" contains inconsistent casing with lowercase 'dd' while other octets use uppercase. MAC addresses should use consistent casing. Based on the codebase pattern seen in rrd_sysinfo.c (e.g., "D4:52:EE:58:F6:AE"), all hexadecimal digits should be uppercase for consistency.
| echo "AA:BB:CC:dd:EE:FF" >> /tmp/.estb_mac | |
| echo "AA:BB:CC:DD:EE:FF" >> /tmp/.estb_mac |
| // 6.5. Handle LOGUPLOAD_ENABLE special case (matching shell script lines 128-131) | ||
| if (strcmp(issue_type_sanitized, "LOGUPLOAD_ENABLE") == 0) { | ||
| RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "%s: Handling LOGUPLOAD_ENABLE - checking for live logs\n", __FUNCTION__); | ||
| RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "%s: Check and upload live device logs for the issuetype\n", __FUNCTION__); |
There was a problem hiding this comment.
The log message uses "issuetype" (all lowercase) which is inconsistent with other log messages that use "ISSUETYPE" or "issue_type". For consistency with the codebase style, this should be "issue type" (two words) or match the variable naming convention used elsewhere.
| RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "%s: Check and upload live device logs for the issuetype\n", __FUNCTION__); | |
| RDK_LOG(RDK_LOG_INFO, LOG_REMDEBUG, "%s: Check and upload live device logs for the issue type\n", __FUNCTION__); |
Code Coverage Summary |
Code Coverage Summary |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RDKEMW-12334-The log entries in remote-debugger.log