rebase #156

Abhinavpv28 · 2025-09-24T15:38:16Z

No description provided.

Create deepsleep_main.c Update Makefile Create power_controller.h Update run_l2.sh Update cov_build.sh Create pwrMgr.h Update cov_build.sh Update cov_build.sh Update Makefile Rename deepsleep_main.c to main.c Update Makefile update Makefile Delete test/functional-tests/tests/rrdIarmEvents.c Update run_l2.sh Update remote_debugger.json Update remote_debugger.json Create test_deepsleep_static.py Update run_l2.sh Update run_l2.sh Create test_deepsleep_dynamic.py Update run_l2.sh Update rrdInterface.c Update create_json.sh Create test_append.py Create test_category.py Update test_rrd_dynamic_profile_missing_report.py Create test_rrd_dynamic_with_download_harmful.py Create test_rrd_negative.py Update configure.ac Update cov_build.sh Update run_l2.sh Update main.c Rename main.c to deepsleep_main.c Update Makefile Create rrd_append_report.feature Create rrd_deepsleep_static.feature Create rrd_deepsleep_dynamic.feature Create rrd_dynamic_with_download_harmful_report.feature Update rrd_dynamic_profile_missing_report.feature Update test_rrd_dynamic_profile_missing_report.py Update cov_build.sh Update test_rrd_single_instance.py Update test_category.py Update run_l2.sh Update test_rrd_dynamic_profile_missing_report.py Update rrdInterface.c Update rrdInterface.c Update rrdInterface.c Update rrdIarmEvents.c Update rrdIarmEvents.c Delete test/functional-tests/tests/test_deepsleep_dynamic.py Delete test/functional-tests/tests/test_rrd_negative.py Update run_l2.sh Update test_category.py Update cov_build.sh Update configure.ac Update configure.ac Delete test/functional-tests/features/rrd_deepsleep_dynamic.feature Update rrd_dynamic_profile_missing_report.feature Update rrd_dynamic_profile_missing_report.feature Delete test/functional-tests/tests/test_rrd_dynamic_with_download_harmful.py Delete test/functional-tests/tests/deepsleep_main.c Delete test/functional-tests/tests/Makefile Update run_l2.sh Update run_l2.sh Delete test/functional-tests/features/rrd_dynamic_with_download_harmful_report.feature Create rrd_dynamic_profile_subcategory_report.feature Update run_l2.sh Rename test_append.py to test_rrd_append_report.py Rename test_category.py to test_rrd_dynamic_subcategory_report.py Rename test_deepsleep_static.py to test_rrd_deepsleep_static_report.py Rename rrd_deepsleep_static.feature to rrd_deepsleep_static_report.feature Update rrd_dynamic_profile_missing_report.feature Update rrd_dynamic_profile_missing_report.feature Update rrd_dynamic_profile_missing_report.feature

RDK-56291 - [RDKE] Increase L2 Test Coverage For Remote Debugger : Target 80% [ Phase 2 ]

…elop Deploy cla action

Deploy fossid_integration_stateless_diffscan_target_repo action

…rget 80% [ Phase 2 ] (#157) * Update rrdInterface.c * Update rrdIarmEvents.c * Update configure.ac * Update cov_build.sh * Update remote_debugger.json * Update create_json.sh * Create Makefile * Create deepsleep_main.c --------- Co-authored-by: nhanasi <navihansi@gmail.com>

RRD 1.2.9 release

CLAassistant · 2025-10-01T18:24:46Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ Alan-Ryan
✅ Abhinavpv28
✅ venkat0557
❌ naveenkumarhanasi
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

… C (#167) * Add comprehensive HLD documentation for uploadRRDLogs.sh migration to C - Requirements document with functional specs, I/O definitions, and constraints - High-Level Design with architecture, module breakdown, and data flows - Detailed flowcharts for all major operations (Mermaid + text-based) - Sequence diagrams showing component interactions - Low-Level Design with complete C code, data structures, and implementations Documentation covers migration of uploadRRDLogs.sh to embedded C program optimized for low-memory, low-CPU embedded systems with full error handling, security considerations, and platform portability. - Replace custom MAC retrieval logic with TR-181 parameters via RBus - Device.DeviceInfo.X_COMCAST-COM_STB_MAC (Video) - Device.DeviceInfo.X_COMCAST-COM_CM_MAC (Broadband) - Device.X_CISCO_COM_MACAddress (Alternative) - Add cache file fallback (/tmp/device_details.cache, /tmp/estb_mac) - Add early exit optimization in config parser when all required properties found - Mark libarchive as mandatory dependency, remove tar command fallback

Copilot

Pull request overview

This PR appears to be a rebase that includes significant additions for L2 test coverage improvements and new documentation for an uploadRRDLogs C implementation. The changes include:

Enhanced test coverage with new test files and improved existing tests
Comprehensive documentation for uploadRRDLogs migration from shell script to C
New power management integration with deepsleep functionality
Build system improvements with L2 support configuration
Updated CI/CD workflows and project maintenance files

Reviewed changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
test/functional-tests/tests/test_rrd_single_instance.py	Improved PID handling with proper list operations
test/functional-tests/tests/test_rrd_dynamic_subcategory_report.py	New comprehensive test for dynamic subcategory reporting
test/functional-tests/tests/test_rrd_deepsleep_static_report.py	New test for deepsleep static report functionality
test/functional-tests/tests/test_rrd_append_report.py	New test for report append functionality
test/functional-tests/tests/power_controller.h	New power controller API header with comprehensive interface
test/functional-tests/tests/deepsleep_main.c	New C test implementation for deepsleep event handling
test/functional-tests/tests/create_json.sh	Updated JSON creation with additional test configurations
test/functional-tests/tests/Makefile	New Makefile for compiling C test binaries
test/functional-tests/features/*.feature	New Gherkin feature files for BDD test scenarios
src/unittest/mocks/pwrMgr.h	New mock header for power manager IARM interface
src/rrdInterface.c	Updated RBus subscription logic with L2 support conditionals
src/rrdIarmEvents.c	Updated WebCfg force sync error handling with L2 support
run_l2.sh	Added new test executions and configuration copy
remote_debugger.json	Added DeepSleep configuration profiles
docs/uploadRRDLogs_*.md	New comprehensive documentation for uploadRRDLogs C migration
cov_build.sh	Updated build script with L2 support flags
configure.ac	Added L2 support configuration option
CHANGELOG.md	Updated with 1.2.9 release notes
.github/workflows/*.yml	Updated CI/CD workflows with improved security
.github/CODEOWNERS	Simplified code ownership

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T23:07:16Z

test/functional-tests/tests/test_rrd_deepsleep_static_report.py

+    DEBUG_FILE = "Adding Details of Debug commands to Output File"
+    assert DEBUG_FILE in grep_rrdlogs(DEBUG_FILE)
+
+    issue_string = "DEEPSLEEP"


Variable issue_string is not used.

Suggested change

issue_string = "DEEPSLEEP"

Copilot · 2025-12-04T23:07:16Z

test/functional-tests/tests/test_rrd_append_report.py

@@ -0,0 +1,134 @@
+import json
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Suggested change

from helper_functions import *

from helper_functions import (

check_file_exists,

check_directory_exists,

kill_rrd,

remove_logfile,

run_shell_silent,

run_shell_command,

grep_rrdlogs,

JSON_FILE,

OUTPUT_DIR,

APPEND_JSON_FILE,

DYNAMIC_DIR,

)

Copilot · 2025-12-04T23:07:17Z

test/functional-tests/tests/test_rrd_deepsleep_static_report.py

+# limitations under the License.
+##########################################################################
+
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Suggested change

from helper_functions import *

from helper_functions import (

JSON_FILE,

check_file_exists,

OUTPUT_DIR,

check_directory_exists,

kill_rrd,

remove_logfile,

run_shell_silent,

run_shell_command,

grep_rrdlogs,

remove_outdir_contents

)

Copilot · 2025-12-04T23:07:17Z

test/functional-tests/tests/test_rrd_dynamic_subcategory_report.py

+
+import json
+import subprocess
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Suggested change

from helper_functions import *

from helper_functions import (

JSON_FILE,

check_file_exists,

OUTPUT_DIR,

check_directory_exists,

kill_rrd,

remove_logfile,

run_shell_silent,

run_shell_command,

sleep,

grep_rrdlogs,

)

Copilot · 2025-12-04T23:07:17Z

test/functional-tests/tests/test_rrd_dynamic_subcategory_report.py

+# limitations under the License.
+##########################################################################
+
+import json


Import of 'json' is not used.

Suggested change

import json

* RDK-58172: integrate dcm-agent uploadstblogs and cleanup logging; update Makefile and upload flow * Add unit tests for RRD upload orchestration This file contains unit tests for the RRD upload orchestration, covering various aspects such as configuration loading, system information retrieval, log directory validation, and the entire upload workflow. * Update Makefile.am * Remove uploadRRDLogs program from Makefile * Refactor uploadDebugoutput to use upload API Updated the uploadDebugoutput function to call the upload API instead of executing a script. Enhanced logging for upload orchestration success and failure. * Refactor upload orchestration into rrd_upload_orchestrate Refactor upload orchestration logic into a separate function and remove deprecated main function. * Update rrd_config.h * Include common_device_api.h in rrd_sysinfo.h Added inclusion of common_device_api.h for device API access. * Add comprehensive functional tests for C API upload orchestration - Add BDD feature file with 20 test scenarios for rrd_upload_orchestrate - Add Python test implementation with 14 test functions - Test coverage includes: * Valid and invalid parameter handling * Configuration loading from multiple sources (properties, RFC, DCM) * MAC address retrieval and timestamp generation * Issue type sanitization and normalization * Archive creation and format validation * Upload execution and lock handling * Cleanup operations * Error code propagation (codes 1-11) * Comprehensive logging verification * Integration with uploadDebugoutput wrapper - Tests validate the complete flow from event trigger through C API execution to upload completion - Helper class provides utilities for test setup, archive validation, and log verification Refactor source validation and log handling. Improve error handling for directory operations and add functionality to move live logs. * Refactor log upload handling and cleanup process Updated log upload process to handle LOGUPLOAD_ENABLE case and adjusted archive creation and upload paths.

rdkcmf-jenkins and others added 4 commits June 24, 2025 15:09

Deploy cla action

43c072b

Merge pull request #147 from rdkcentral/feature/deepsleepl2

cbea8fc

RDK-56291 - [RDKE] Increase L2 Test Coverage For Remote Debugger : Target 80% [ Phase 2 ]

Update CODEOWNERS

4c0a052

Abhinavpv28 requested a review from a team as a code owner September 24, 2025 15:38

rdkcmf-jenkins and others added 9 commits September 25, 2025 18:24

Merge branch 'develop' into feature/action-deploy-for/develop

1df05e1

Deploy cla action

7d615b3

Merge pull request #137 from rdkcentral/feature/action-deploy-for/dev…

0e466a4

…elop Deploy cla action

Deploy fossid_integration_stateless_diffscan_target_repo action

e941880

Merge pull request #163 from rdkcentral/feature/actions/develop-fossid

1f51cb5

Deploy fossid_integration_stateless_diffscan_target_repo action

RRD 1.2.9 release changelog updates

534594c

Merge branch 'release/1.2.9' into main

300d29e

Merge tag '1.2.9' into develop

d790168

RRD 1.2.9 release

Copilot AI review requested due to automatic review settings December 4, 2025 23:03

Copilot started reviewing on behalf of shibu-kv December 4, 2025 23:04 View session

Copilot finished reviewing on behalf of shibu-kv December 4, 2025 23:04

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rebase #156

rebase #156

Uh oh!

Abhinavpv28 commented Sep 24, 2025

Uh oh!

CLAassistant commented Oct 1, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Copilot AI Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

-from helper_functions import *
+from helper_functions import (
+    check_file_exists,
+    check_directory_exists,
+    kill_rrd,
+    remove_logfile,
+    run_shell_silent,
+    run_shell_command,
+    grep_rrdlogs,
+    JSON_FILE,
+    OUTPUT_DIR,
+    APPEND_JSON_FILE,
+    DYNAMIC_DIR,
+)

rebase #156

Are you sure you want to change the base?

rebase #156

Uh oh!

Conversation

Abhinavpv28 commented Sep 24, 2025

Uh oh!

CLAassistant commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

CLAassistant commented Oct 1, 2025 •

edited

Loading