Skip to content

fix(sdk): add filter config to old tokens view#1655

Closed
rohilsurana wants to merge 1 commit into
mainfrom
token-page-filters
Closed

fix(sdk): add filter config to old tokens view#1655
rohilsurana wants to merge 1 commit into
mainfrom
token-page-filters

Conversation

@rohilsurana
Copy link
Copy Markdown
Member

@rohilsurana rohilsurana commented May 27, 2026

Summary

  • Add enableColumnFilter, filterType, and filterOptions to the old tokens view columns (used by OrganizationProfile)
  • Add DataTable.Filters trigger button to the transactions table
  • Add missing system.overdraft event source to TxnEventSourceMap
  • Fixes: token transaction filters on hue.pixxel.dev were showing 0 results because the Event column had no filter configuration — the DataTable auto-generated filter options from raw source values but couldn't match them during client-side filtering

Related: The billing page "Upgrade" button not working on hue.pixxel.dev is a studio-side issue — BillingView accepts onNavigateToPlans but the studio app wasn't passing it. Fixed in pixxelhq/studio#2665.

Test plan

  • Open tokens page in OrganizationProfile → verify Filter button appears
  • Click Filter → Event → select "Recharge" → verify table shows only recharge transactions
  • Click Filter → Date → verify date range filter works
  • Clear filters → verify all transactions show again

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
frontier Ready Ready Preview, Comment May 27, 2026 8:25am

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8ab6920-b2f7-43fe-a7dd-afca03caed46

📥 Commits

Reviewing files that changed from the base of the PR and between e399d9c and 5211adc.

📒 Files selected for processing (2)
  • web/sdk/react/views/tokens/transactions/columns.tsx
  • web/sdk/react/views/tokens/transactions/index.tsx

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • New Features
    • Added multiselect filtering for transaction events, allowing users to filter by multiple event types simultaneously.
    • Extended support for additional transaction event types in the transactions view.
    • Introduced a dedicated filter UI button for improved accessibility and discoverability of filtering options.

Walkthrough

The PR extends transaction table filtering by typing and expanding the event source map, configuring Date and Event columns with explicit filter types and options, and rendering a filter button in the table UI to expose these filters to users.

Changes

Transaction Table Filtering

Layer / File(s) Summary
Column filter configuration
web/sdk/react/views/tokens/transactions/columns.tsx
TxnEventSourceMap is now typed as Record<string, string> and includes system.buy, system.overdraft, and system.revert entries. eventFilterOptions is derived from this map. The Date column explicitly enables date filtering, and the Event column is configured for multiselect filtering using eventFilterOptions.
Filter UI rendering
web/sdk/react/views/tokens/transactions/index.tsx
FilterIcon is imported and DataTable.Filters is rendered with a neutral small "Filter" button featuring the icon, enabling users to access the configured column filters.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • raystack/frontier#1517: Both PRs modify the billing transactions table column configuration to introduce/extend TxnEventSourceMap-driven Event multiselect filtering with filterOptions mapped from the event source map.

Suggested reviewers

  • rsbh
  • paanSinghCoder
  • rohanchkrabrty
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26499857270

Coverage remained the same at 42.847%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 37846
Covered Lines: 16216
Line Coverage: 42.85%
Coverage Strength: 12.0 hits per line

💛 - Coveralls

@rohilsurana
Copy link
Copy Markdown
Member Author

Closing - the old tokens view is no longer used, the new views-new/ tokens view already has proper filter config.

@rohilsurana rohilsurana deleted the token-page-filters branch May 27, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants