fix(sdk): add filter config to old tokens view#1655
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThe PR extends transaction table filtering by typing and expanding the event source map, configuring Date and Event columns with explicit filter types and options, and rendering a filter button in the table UI to expose these filters to users. ChangesTransaction Table Filtering
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 26499857270Coverage remained the same at 42.847%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Closing - the old tokens view is no longer used, the new views-new/ tokens view already has proper filter config. |
Summary
enableColumnFilter,filterType, andfilterOptionsto the old tokens view columns (used byOrganizationProfile)DataTable.Filterstrigger button to the transactions tablesystem.overdraftevent source toTxnEventSourceMapsourcevalues but couldn't match them during client-side filteringRelated: The billing page "Upgrade" button not working on hue.pixxel.dev is a studio-side issue —
BillingViewacceptsonNavigateToPlansbut the studio app wasn't passing it. Fixed in pixxelhq/studio#2665.Test plan