Skip to content

fix: scroll sidebar to active item on navigation #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsbh merged 1 commit into from
May 27, 2026
Merged

fix: scroll sidebar to active item on navigation #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions packages/chronicle/src/themes/default/Layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ function renderConfigIcon(
return <img src={icon} alt={alt} className={styles.configIcon} />;
}

let savedScrollTop = 0;

export function Layout({
children,
config,
Expand Down Expand Up @@ -97,22 +95,20 @@ export function Layout({
);

useEffect(() => {
const el = scrollRef.current;
if (!el) return;
const onScroll = () => {
savedScrollTop = el.scrollTop;
};
el.addEventListener('scroll', onScroll);
return () => el.removeEventListener('scroll', onScroll);
}, []);

useEffect(() => {
const el = scrollRef.current;
if (el)
requestAnimationFrame(() => {
el.scrollTop = savedScrollTop;
});
const timer = setTimeout(() => {
const container = document.querySelector<HTMLElement>(`.${styles.sidebarMain}`);
if (!container) return;
const allActive = container.querySelectorAll<HTMLElement>('[data-active="true"]');
const activeItem = allActive[allActive.length - 1];
if (!activeItem) return;
const containerRect = container.getBoundingClientRect();
const itemRect = activeItem.getBoundingClientRect();
if (itemRect.top < containerRect.top || itemRect.bottom > containerRect.bottom) {
container.scrollTop += itemRect.top - containerRect.top - containerRect.height / 2 + itemRect.height / 2;
}
}, 100);
setMobileSidebarOpen(false);
return () => clearTimeout(timer);
}, [pathname]);

return (
Expand Down Expand Up @@ -436,6 +432,7 @@ function ApiSidebarNode({ item, pathname }: { item: Node; pathname: string }) {
align='center'
gap={3}
className={`${styles.apiItem} ${isActive ? styles.apiItemActive : ''}`}
data-active={isActive}
render={<RouterLink to={href} />}
>
<span className={styles.apiItemName}>{item.name}</span>
Expand Down
Loading