Skip to content

fix: design QA sidebar spacing and alignment#111

Merged
rsbh merged 4 commits into
mainfrom
fix/design-qa-sidebar-spacing
May 27, 2026
Merged

fix: design QA sidebar spacing and alignment#111
rsbh merged 4 commits into
mainfrom
fix/design-qa-sidebar-spacing

Conversation

@rsbh
Copy link
Copy Markdown
Member

@rsbh rsbh commented May 27, 2026

Summary

Fixes from design QA (sidebar spacing and alignment):

  • Sub-nav horizontal padding → 28px per Figma
  • Remove extra bottom padding on card wrapper (green padding issue)
  • Remove gap between top link items in sidebar
  • Section spacing at 24px between nav groups

Test plan

  • Sidebar items left-aligned with logo
  • No extra padding below content card
  • Sub-nav padding matches Figma (28px)
  • Top links (Documentation/Dev Guide/API) have no extra gap
  • Build and tests pass

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown

vercel Bot commented May 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
chronicle Ready Ready Preview, Comment May 27, 2026 4:02am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Review Change Stack

Warning

Review limit reached

@rsbh, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 51 minutes and 15 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b148a7dd-e5c6-4fd3-8f94-8f6e2478bd9a

📥 Commits

Reviewing files that changed from the base of the PR and between 818b196 and ea0b67f.

📒 Files selected for processing (1)
  • packages/chronicle/src/themes/default/Layout.module.css
📝 Walkthrough

Walkthrough

This PR refines layout spacing and flexbox styling in the default theme's Layout.module.css. Changes include converting .topLinks to a flex-column layout, zeroing .cardWrapper padding, adjusting .subNav spacing variables, tightening .navGroupHeader spacing, and adding a new rule to reset h3 margins within sidebar nav-group elements.

Changes

Default Theme Layout Styling

Layer / File(s) Summary
Layout spacing and flex adjustments
packages/chronicle/src/themes/default/Layout.module.css
.topLinks adopts a flex-column layout with zero gap. .cardWrapper padding is simplified to 0. .subNav spacing variables are updated to --rs-space-8. .navGroupHeader margins and padding are tightened. A new nested selector targets h3 elements within sidebar nav-group classes to zero their margins.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title directly and specifically describes the main changes: design QA fixes for sidebar spacing and alignment.
Description check ✅ Passed The description is clearly related to the changeset, providing detailed context about design QA fixes with specific pixel values and a test plan aligned with the CSS changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/design-qa-sidebar-spacing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Sub-nav horizontal padding: 24px → 28px
- Remove extra bottom padding on cardWrapper
- Remove gap between top link items
- Section spacing maintained at 24px

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove margin-bottom from topLinks
- Nav group header: zero top/bottom padding, 12px margin-bottom
- Remove h3 margin inside sidebar nav groups

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace global selector hack with scoped .navGroupHeader h3.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rsbh rsbh merged commit d232664 into main May 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants