-
Notifications
You must be signed in to change notification settings - Fork 13
fix: a11y baseline pass across components #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
8293642
3cc7513
7a4b53f
1dbcf7b
a46a251
c666a70
5288593
8deb769
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -41,7 +41,19 @@ | |||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .action-btn { | ||||||||||||||
| display: flex; | ||||||||||||||
| display: inline-flex; | ||||||||||||||
| align-items: center; | ||||||||||||||
| gap: var(--rs-space-1); | ||||||||||||||
| cursor: pointer; | ||||||||||||||
| background: transparent; | ||||||||||||||
| border: 0; | ||||||||||||||
| padding: 0; | ||||||||||||||
| font: inherit; | ||||||||||||||
| color: inherit; | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| .action-btn:focus-visible { | ||||||||||||||
| outline: 2px solid currentColor; | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix Stylelint keyword-case violation on Line 56.
Proposed fix-.action-btn:focus-visible {
- outline: 2px solid currentColor;
+.action-btn:focus-visible {
+ outline: 2px solid currentcolor;
outline-offset: 2px;
border-radius: var(--rs-radius-1);
}📝 Committable suggestion
Suggested change
🧰 Tools🪛 Stylelint (17.11.0)[error] 56-56: Expected "currentColor" to be "currentcolor" (value-keyword-case) (value-keyword-case) 🤖 Prompt for AI Agents |
||||||||||||||
| outline-offset: 2px; | ||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use variable here |
||||||||||||||
| border-radius: var(--rs-radius-1); | ||||||||||||||
| } | ||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this as per design to put a focus-visible state here? If not let's take it up with the
focus-visiblemilestone