feat (3-breadcrumb): add href support and expose data-disabled and data-current attributes#669
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| @@ -14,6 +14,9 @@ import styles from './breadcrumb.module.css'; | |||
|
|
|||
| export interface BreadcrumbDropdownItem { | |||
There was a problem hiding this comment.
I think it's better to accept all MenuItem props at this point here and let users handle it, instead of creating one off handlers in code
Breadcrumb 3rd PR
Issue-600
Description
data-disabledanddata-currentattributesType of Change
How Has This Been Tested?
Unit tests and manual
Checklist:
Screenshots (if appropriate):
[Add screenshots here]
Related Issues
[Link any related issues here using #issue-number]