Improve General Count Accuracy by Ignoring Build Files#62
Open
kilo52 wants to merge 3 commits into
Open
Conversation
Added a function in the directory scanning implementations that checks for common directory names containing build files that should be ignored. Those directories are 'build', 'bin', 'target', 'dist'. Directories designated for binary files and build artifacts can sometimes also contain copies of files in the source tree and automatically generated files by build-chains. Those files should not contribute to the result counts of the program. [CL]: Changed scanDirectory() to ignore directory entries with known names. [Issue#61] Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Removed duplicated shouldIgnoreDirectory() definitions. Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
Signed-off-by: Phil Gaiser <phil.gaiser@raven-computing.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes what directories get scanned for files, specifically what directories get ignored. Previously, all directories were included in the count file set. This change adds a function in the directory scanning implementations that checks for common directory names containing build files that should be ignored. This is because directories designated for binary files and build artifacts can sometimes also contain copies of files in the source tree and automatically generated files by build-chains. Those files should not contribute to the result counts of the program.