net: bcmgenet: fix leaking and racing timeout handler#7300
Draft
nbuchwitz wants to merge 1 commit intoraspberrypi:rpi-6.18.yfrom
Draft
net: bcmgenet: fix leaking and racing timeout handler#7300nbuchwitz wants to merge 1 commit intoraspberrypi:rpi-6.18.yfrom
nbuchwitz wants to merge 1 commit intoraspberrypi:rpi-6.18.yfrom
Conversation
The bcmgenet_timeout handler tries to take down all tx queues when a single queue times out. This is over zealous and causes many race conditions with queues that are still chugging along. Instead lets only restart the timed out queue. While reclaiming the tx queue we fast forward the write pointer to drop any data in flight. These dropped frames are not added back to the pool of free bds. We also need to tell the netdev that we are dropping said data. Signed-off-by: Justin Chen <justin.chen@broadcom.com> Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de> Tested-by: Nicolai Buchwitz <nb@tipi-net.de> Fixes: f1bacae ("net: bcmgenet: support reclaiming unsent Tx packets") Fixes: 13ea657 ("net: bcmgenet: improve TX timeout") Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible fix of #7024
Need the CI builds, so people can test and provide feedback if at least the lockup is gone with this. Do not merge.