-
Notifications
You must be signed in to change notification settings - Fork 56
[Improvement] Added support for authorizing using the Phone #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is by using a generated QR Code on where the calendar should be
randomBrainstormer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job, and thank you for the PR! I really appreciate the effort you put into this.
The changes look great, and the Pull Request is well-structured. The code changes align perfectly with the PR's purpose. Overall, you've done an excellent job! I only have a few minor comments/suggestions that I'd like you to address before we merge. Once those are resolved, we'll be good to go. Keep up the good work, and thank you for your valuable contribution!
Co-authored-by: Iván <ivan.r.severino@gmail.com>
|
Thanks!!! I'm glad that you liked the Pull Request. I resolved both changes, but now I've found a new big issue, and it's that Google doesn't like private IPs neither The only workaround is to set a false domain on So, TL;DR: I don't know if you would want to proceed with this type of authorizing, because it becomes very hackish to do for the end-user (for me and maybe for many developers it's not that hard, I do have a domain and also a Pi.hole server, but I want to think about those random people who came here and are not that technician like us) |
Thanks for diving into this. I get the tech hurdles we're facing. Asking users, especially those not super tech-savvy, to mess with the Maybe we need to rethink the whole phone authorization thing or whip up a super clear step-by-step guide. Though, gotta admit, it could still be a puzzle for some. Got any ideas ? What if we let users toggle this feature on right from the plugin's settings? That way, we keep the flow smooth and just beef it up for folks wanting a bit more. |
|
Sorry for the delay! I have a crazy week right now! Yeah! It's a total mess. Thinking about it, this will help to a handful of people actually, specially those who cannot have a keyboard/mouse attached to the mirror (on my case, I fried up the only USB port, and the board is sooooooooooooo slow so I cannot have any type of remote desktop on it), so it could be a good idea to leave it as an optional (disabled by default) setting. Not sure if doing a guide would help though. I mean, we can link or re-use the documentation from pi.hole for example, but for me, a tech savvy, it took too much effort to make it work, even with the official documentation on hand, and many other guides on internet. Anyway, I'll try to give it a little rework this weekend, but I'll use this same pull request, as it shouldn't change that much |
This is by using a generated QR Code on where the calendar should be.
This just add a new method, and
authorize.jsshould be working fine when usingDesktop Appas before.Sadly, the request URL is so big, so it generates a big QR Code, but it should be working just fine even on pretty small (relatively speaking) screens.