Skip to content

Conversation

@KristjanESPERANTO
Copy link

This PR removes all unnecessary dependencies. They made it difficult to install the module, as several error messages appeared during npm install.

@ralberth
Copy link
Owner

Excellent PR! Thanks for taking the time to do this. I'll do you one better: this repo isn't actively developed anymore, but generally works. Instead of depending on the specific locked, transitive dependencies in package-lock.json, I just removed the file entirely. This way, each build picks up the latest dependency minor versions and avoids obvious CVEs, etc. Do a 'git pull' to grab the last commit.

Thanks for caring and sending in a PR!

@ralberth ralberth closed this Dec 28, 2025
@KristjanESPERANTO
Copy link
Author

Unfortunately, removing package-lock.json didn't help. The dependencies I wanted to remove with the PR are still listed in package.json.

@ralberth
Copy link
Owner

Crap, sorry. Didn't read the whole PR :-( Problem of knocking out todos on a weekend afternoon.
I removed a bunch from package.json, have a 'git pull' and LMK.

@ralberth ralberth reopened this Dec 28, 2025
@KristjanESPERANTO
Copy link
Author

I have updated my PR to the current status of your repository. In addition to removing the redundant dependency, I have also addressed a few minor issues listed here on the module check page. No logical changes, just chores 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants