Don't set encryptor purpose when using default key#56
Open
themichaelyang wants to merge 1 commit intorack:mainfrom
Open
Don't set encryptor purpose when using default key#56themichaelyang wants to merge 1 commit intorack:mainfrom
purpose when using default key#56themichaelyang wants to merge 1 commit intorack:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this is my first contribution!
This PR closes #35;
rake testpasses all tests.I decided to preserve the
purpose: nilbehavior when the default key is passed to avoid breaking cookies using the existing default behavior (e.g. without an explicitkey: "rack.session").There was a typo in the
"rejects session cookie with different purpose"test.@secrets(with an -s) is undefined, but switching to@secret(no -s, defined on line 77) allowed the reported issue to fail in the new test prior to the fix.