ci: test against a compatible connection_pool version

[santib]

CI started failing since connection_pool 3 was released https://github.com/rack/rack-attack/actions/runs/20482828723

It's an indirect dependency, but our dependencies weren't prepared for these breaking changes on connection_pool

[grzuy]

Good catch 💯

[santib]

redis_4, redis_5, and redis_store gemfiles need it but it isn't because of redis, it's because of activesupport being installed as a dev dependency which seems unfortunate, but when trying to remove it lot of tests failed so I think we can work on that separately if we ever want to cc @grzuy

[grzuy]

Gotcha.
And we can't solve it by listing connection_pool 2.5 as an additional dev dependency in the gemspec, because that would affect tests that try testing when connection_pool is not present, right?

[santib]

oh I see.. I guess you are referring to this commit .. I guess that behavior got "ignored" since activesupport was added directly as a dev dependency on the gemspec, and therefore connection_pool available for all gemfiles.. 😅

At this point, since activesupport was added, the "pooled" versions of the gemfiles aren't adding any value since they are all "pooled", so I added a commit just cleaning up the spec gemfiles. Or do you think there is value in going back to testing "pooled" and "not pooled" versions, and we should go in the opposite direction removing activesupport dev dependency and such?

EDIT:

In summary I think we have many different options:

1. Just add connection_pool on the Appraisals to get the CI green
2. Add connection_pool in the gemspec given that activesupport is already there + remove duplicated gemfiles (pooled)
3. Remove activesupport from the gemspec + Add connection_pool on the Appraisals