Add per-context interrupt budget#1526
Open
dannote wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a context-local interrupt counter and optional limit.
The counter increments when the interpreter reaches the existing interrupt polling path. If a context limit is set and the counter reaches it, that context throws
interruptedbefore consulting the runtime-level interrupt handler. A limit of0keeps the feature disabled.This is useful for embedders that host multiple
JSContextinstances inside oneJSRuntimeand need each context to have an independent execution budget. In QuickBEAM, a pool worker owns oneJSRuntimeand creates many contexts withJS_NewContext(rt). A runtime-level interrupt handler remains useful as a global guard, but it cannot express a per-context budget for that pooled model.Tested: