Conversation
meson_options.txt
Outdated
| option('cli_mimalloc', type: 'feature', value: 'disabled', description: 'build qjs cli with mimalloc') | ||
| option('docdir', type: 'string', description: 'documentation directory') | ||
| option('parser', type: 'boolean', value: true, description: 'Enable JS source code parser') | ||
| option('libonly', type: 'boolean', value: false, description: 'Build qjs library only') |
There was a problem hiding this comment.
It's probably better to have a
option('tools', type: 'feature', description: 'build tools like qjs and qjsc')
as libonly is a really weird option name IMHO.
There was a problem hiding this comment.
Idn't there a convention projects using meson use?
There was a problem hiding this comment.
'tools' seems a bit more natural to me. That's what we use in Gentoo to denote binaries that come with projects that are primarily used as libraries. e.g. see this: https://packages.gentoo.org/useflags/search?q=tools
|
I'd suggest forcing building the binaries if tests are enabled. For instance, if you disable 'tools' and enable tests, you can build but not install the binaries. |
|
Additionally, please describe your changes in the commit messages in a bit greater detail, as, for example, described here:
In this case, something like |
Also: a) do not check dependecy 'threads' in 'dos' build (No -pthread in djgpp) b) replace qjsc_exe by 'qjsc' in codegen targets. qjsc_exe compiles quickjs-libc.c
|
I already have 3 commits. Is it possible to squashed them to 1 without closing merge request? |
How to do that? |
4 participants
Mainly for DJGPP. I don't need qjs.exe, libc. etc. only library.
Check for threads adds -pthread to flags, which cause compilation error, so it is disabled for 'dos' host_system.
Executables are replaced by text '/bin/true'. It does not break normal builds.