Fix Windows dart-sass path quoting with spaces #14002
Merged
+299
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deno has a bug when executing .bat files where both the command path and arguments contain spaces. This causes dart-sass to fail when Quarto is installed in C:\Program Files\ and project paths have spaces. Use safeWindowsExec on Windows to write the command to a temp batch file with proper quoting, bypassing Deno's buggy command-line handling. Closes #13997 Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
C:\Program Files\)Root Cause
On Windows, when both the dart-sass executable path AND the arguments contain spaces, Deno's process execution fails to properly handle the quoting. The error appears as:
Fix
Refactored
dartCommand()to use existingsafeWindowsExec()andrequireQuoting()utilities fromwindows.tson Windows. These utilities:cmd /cto avoid Deno's quoting issuesFixes #13997
🤖 Generated with Claude Code