Block Invariant Symmetry Shift functionality #904
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new module and function compute_lambda_df_with_bliss_post_processing to compute the lambda value for a double-factorized Hamiltonian with BLISS post-processing of double factorization fragments. It also includes corresponding unit tests to verify the correctness of the implementation. There are no review comments to address, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@SmikPatel Thank you for this work, and my apologies for the long delay in replying. This looks reasonable and we'd like to work on getting it into OpenFermion. When you have a moment, could you please update your branch on GitHub? Before we add code review comments, it would be best to work on an updated version of the code. 
|
2 participants
Added a function to calculate the 1-norm of DF post-processed with block invariant symmetry shifts (DF+LRPS method of https://pubs.acs.org/doi/abs/10.1021/acs.jctc.4c01390), along with a test.