u-boot: Add multi-DTB support and critical fixes#1373
u-boot: Add multi-DTB support and critical fixes#1373aswinm94 wants to merge 1 commit intoqualcomm-linux:masterfrom
Conversation
aswinm94
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
@aswinm94 oe-core is about to catch up with U-Boot 2026.01 release. Please make sure these patches cleanly apply on top of this. Ref: https://lists.openembedded.org/g/openembedded-core/topic/117103773 |
Hi @vkraleti, these patches were generated on top of U-Boot 2026.01 release |
aswinm94
force-pushed
the
develop
branch
3 times, most recently
from
154231f to
b93dee2
Compare
|
|
||
| [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/soc/qcom/socinfo.h?id=7dcc1dfaa3d1cd3aafed2beb7086ed34fdb22303 | ||
|
|
||
| Upstream-Status: Submitted [https://lore.kernel.org/u-boot/20260106122134.2047864-3-aswin.murugan@oss.qualcomm.com/] |
There was a problem hiding this comment.
Why do we need this patch if you've dropped other patches that depended on it?
There was a problem hiding this comment.
This header is a generic interface used to query SoC details from SMEM. These details are not limited to multi-DTB selection, they will also be utilized for other functionalities, such as OF live Device Tree fixups [1]
[1] https://lore.kernel.org/all/20260113115404.1448759-1-aswin.murugan@oss.qualcomm.com/
There was a problem hiding this comment.
It should be pulled when necessary.
Regarding the series you've linked, I'd second Casey's question. You are adding the data to DT, but it can be read from SMEM by Linux too. I don't see a reason to change DT just for the sake of it.
There was a problem hiding this comment.
Removed the patch 0002-soc-qcom-smem-Added-socinfo-header-file.patch.
It will be pulled when necessary.
| Tested on UFS device with sector size 4096 and meta data recorded | ||
| sector size 512. | ||
|
|
||
| Upstream-Status: Submitted [https://lore.kernel.org/u-boot/Z08e6RA9st%2FWmyM0@hu-varada-blr.qualcomm.com/] |
This patch dates back to Nov, 2024. Why isn't there a new spin or resend of that patch for upstream inclusion? |
Test run workflowTest jobs for commit 7aaa878d692ec6d2a6737310d2b1075ec9ad512f
|
Test Results 14 files ±0 14 suites ±0 1h 11m 13s ⏱️ - 28m 50s For more details on these failures, see this check. Results for commit df78368. ± Comparison against base commit dea5470. ♻️ This comment has been updated with latest results. |
I will confirm with the author regarding a respin of this patch. |
Test run workflowTest jobs for commit e70f48af4f2cd3158e0496c0c2a9fefefe4e2eb4
|
Add 3 patches to fix critical issues for Qualcomm platforms: - 0001: Fix SMEM memory region lookup and increase host count to 25 - 0002: Handle FAT sector size mismatch for UFS devices These patches enable hardware detection using SMEM and also fix storage and memory access issues. Signed-off-by: Aswin Murugan <aswin.murugan@oss.qualcomm.com>
| versions that include more remote processors. This avoids failures | ||
| during processor ID checks. | ||
|
|
||
| Upstream-Status: Submitted [https://lore.kernel.org/u-boot/20251112165851.1561418-1-aswin.murugan@oss.qualcomm.com/] |
| Tested on UFS device with sector size 4096 and meta data recorded | ||
| sector size 512. | ||
|
|
||
| Upstream-Status: Submitted [https://lore.kernel.org/u-boot/20241125085213.460723-1-quic_varada@quicinc.com/] |
There was a problem hiding this comment.
It was submitted in 2024. Why was it not merged? Would it be worth resending it? Please work with upstream rather than providing patches which upstream has failed to notice for more than a year.
Test run workflowTest jobs for commit df78368
|
|
Now we have the U-Boot qcom-next staging tree here: https://github.com/qualcomm-linux/u-boot/tree/qcom-next. This tree will track regular U-Boot releases with rebases and currently based on
|
|
Is this PR something that we want to pursue or should it be closed instead? |
We can close it. |
6 participants
u-boot: Add critical fixes for SMEM & storage access
Add 3 patches to fix critical issues for Qualcomm platforms:
upstream link:
[1] https://lore.kernel.org/u-boot/20251112165851.1561418-1-aswin.murugan@oss.qualcomm.com/
[2] https://lore.kernel.org/u-boot/Z08e6RA9st%2FWmyM0@hu-varada-blr.qualcomm.com/
These patches enable hardware detection using SMEM
and also fix storage and memory access issues.