Rotate CV-CUDA Backend#9291
Open
justincdavis wants to merge 28 commits intopytorch:mainfrom
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9291
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New FailuresAs of commit 8d6435d with merge base aa35ca1 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justincdavis
force-pushed
the
feat/rotate_cvcuda
branch
from
cf2f2bc to
ea0bdec
Compare
zy1git
reviewed
Jan 5, 2026
Contributor
zy1git
left a comment
zy1git
left a comment
There was a problem hiding this comment.
I left comments for the first round review. Feel free to let me know your thoughts.
| # CV-CUDA Interp.NEAREST is actually NEAREST_EXACT, it has no direct match | ||
| # Interp handler uses Interp.NEAREST (NEAREST_EXACT) for InterpolationMode.NEAREST | ||
| # As such, we compound error, mostly on borders where padding is added | ||
| assert mae < 122.5 if interpolation is transforms.InterpolationMode.NEAREST else 6, f"MAE: {mae}" |
Contributor
There was a problem hiding this comment.
The 122.5 threshold is quite high. Is this a common practice for CV-CUDA?
| # As such, we compound error, mostly on borders where padding is added | ||
| assert mae < 122.5 if interpolation is transforms.InterpolationMode.NEAREST else 6, f"MAE: {mae}" | ||
| else: | ||
| assert mae < 1 if interpolation is transforms.InterpolationMode.NEAREST else 6, f"MAE: {mae}" |
Contributor
There was a problem hiding this comment.
For enum comparison, "==" is preferred over "is".
| # CV-CUDA Interp.NEAREST is actually NEAREST_EXACT, it has no direct match | ||
| # Interp handler uses Interp.NEAREST (NEAREST_EXACT) for InterpolationMode.NEAREST | ||
| # As such, we compound error, mostly on borders where padding is added | ||
| assert mae < (122.5) if interpolation is transforms.InterpolationMode.NEAREST else 6, f"MAE: {mae}" |
Contributor
There was a problem hiding this comment.
Not sure why the parentheses are added around 122.5 here.
And this line is a bit confusing. Maybe we can rewrite it as:
threshold = 122.5 if interpolation == transforms.InterpolationMode.NEAREST else 6
assert mae < threshold, f"MAE: {mae}"
| """ | ||
| Get the CV-CUDA interpolation mode for a given interpolation mode. | ||
|
|
||
| CV-CUDA has the two following differences (evaluated in tests) comapred to TorchVision/PIL: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the CV-CUDA backend kernel for
rotateTesting
python3 -m pytest test/test_transforms_v2.py::TestRotate