Skip to content

Fix ROCm test builds and enable activity profiler tests#1271

Closed
scotts wants to merge 7 commits intopytorch:mainfrom
scotts:ci_activity_tests
Closed

Fix ROCm test builds and enable activity profiler tests#1271
scotts wants to merge 7 commits intopytorch:mainfrom
scotts:ci_activity_tests

Conversation

@scotts
Copy link
Copy Markdown
Contributor

@scotts scotts commented Feb 24, 2026

We make three changes:

  1. We were not properly turning on ROCm builds for CI tests. Fixes that.
  2. Changes the tests to use nlohmann/json instead of folly's json. This makes it easier to test on GitHub CI as we don't have folly included as an external dependency yet. However, we're doing this through our third-party dependency on dynolog, which is perhaps not ideal. We can explore adding nlohmann/json as a direct third party dependency later.
  3. Enables CUPTI activity profiler test and creates new test target for ROCm activity profiler test.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 24, 2026

Warning: Unknown label ciflow/rocm-mi300.
Currently recognized labels are

  • ciflow/rocm

Please add the new label to .github/pytorch-probot.yml

@scotts scotts marked this pull request as ready for review February 24, 2026 16:02
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 24, 2026

@scotts has imported this pull request. If you are a Meta employee, you can view this in D94228170.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@scotts has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@scotts has updated the pull request. You must reimport the pull request before landing.

@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented Feb 24, 2026

@scotts merged this pull request in 7023dae.

@scotts scotts deleted the ci_activity_tests branch April 4, 2026 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants