Skip to content

Reverts the addition of RemoveNoopPass to the Cortex-M pass manager… #17407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psiddh merged 1 commit into from
Feb 12, 2026
Merged

Reverts the addition of RemoveNoopPass to the Cortex-M pass manager… #17407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions backends/cortex_m/passes/cortex_m_pass_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

from executorch.backends.arm._passes import (
FoldAndAnnotateQParamsPass,
RemoveNoopPass,
ScalarsToAttributePass,
)
from executorch.backends.transforms.remove_getitem_op import RemoveGetItemPass
Expand All @@ -35,7 +34,6 @@ class CortexMPassManager(PassManager):
# Run before folding so qparams attach to max_pool2d values, not tuple + getitem.
RemoveGetItemPass,
FoldAndAnnotateQParamsPass,
RemoveNoopPass,
ReplaceScalarWithTensorArgPass,
ReplaceQuantNodesPass,
ActivationFusionPass,
Expand Down
1 change: 1 addition & 0 deletions backends/cortex_m/test/models/test_mobilenet_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
"executorch_exir_dialects_edge__ops_cortex_m_quantized_conv2d_default": 35,
"executorch_exir_dialects_edge__ops_cortex_m_quantized_depthwise_conv2d_default": 17,
"executorch_exir_dialects_edge__ops_cortex_m_quantized_linear_default": 1,
"executorch_exir_dialects_edge__ops_dim_order_ops__clone_dim_order_default": 1,
}

# Use larger sample set for calibration to get better quantization
Expand Down
Loading