Add meaningful matchers to death tests #17401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace empty string matchers with descriptive patterns that document the expected failure: - operator_registry_test: "registration failed" - operator_impl_example_test: "Unhandled dtype" - scalar_type_util_test: "Unknown ScalarType" - memory_manager_test: "cannot be the same" - method_test: "[0-9]+ >= [0-9]+" - tensor_util_test: "stride of the.*dimension shall" - etdump_test: "before any events are added" - aten_bridge_test: "Strides don't match dim order" Also add et_pal_init() to ET_EXPECT_DEATH macro to initialize PAL in the forked subprocess. Authored with Claude.
rascani
requested review from
Gasoonjia,
JacobSzwejbka,
kirklandsign,
larryliu0820 and
lucylq
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17401
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit 739d0a8 with merge base b4fc4d3 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
rascani
added
release notes: none
lucylq
approved these changes
Feb 11, 2026
meta-cla
bot
added
the
CLA Signed
rascani
commented
Feb 11, 2026
| EXPECT_DEATH_IF_SUPPORTED(_statement, _matcher) | ||
| EXPECT_DEATH_IF_SUPPORTED( \ | ||
| { \ | ||
| et_pal_init(); \ |
Contributor
Author
There was a problem hiding this comment.
Looks like adding this broke the executor_pal_death_test that was testing to make sure other PAL functions failed if this hadn't been called.
Contributor
Author
There was a problem hiding this comment.
Added a EXPECT_DEATH_NO_PAL_INIT variation.
The ET_EXPECT_DEATH macro now calls et_pal_init() in the subprocess, which defeats the purpose of executor_pal_death_test that specifically tests behavior when PAL is NOT initialized. Add a variant that skips PAL initialization for this use case. Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace empty string matchers with descriptive patterns that document the expected failure:
Also add et_pal_init() to ET_EXPECT_DEATH macro to initialize PAL in the forked subprocess.
Authored with Claude.
Test plan