Skip to content

[ET-VK][qconv2d][ez] Don't use im2col path for general convs #17393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SS-JIA wants to merge 3 commits into
base: gh/SS-JIA/424/base
Choose a base branch
from
+1 −18
Open

[ET-VK][qconv2d][ez] Don't use im2col path for general convs #17393

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af4d3b6
[ET-VK][qconv2d][ez] Don't use im2col path for general convs
Feb 11, 2026
e0662f6
Update on "[ET-VK][qconv2d][ez] Don't use im2col path for general convs"
Feb 11, 2026
ec26244
Update on "[ET-VK][qconv2d][ez] Don't use im2col path for general convs"
Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions backends/vulkan/runtime/graph/ops/impl/Q8taConv2d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,24 +401,7 @@ void q8ta_conv2d_general(
}

void q8ta_conv2d(ComputeGraph& graph, const std::vector<ValueRef>& args) {
// Index into args to extract values needed for dispatch decision
const ValueRef packed_int8_input = args.at(0);
const ValueRef kernel_size = args.at(9);
const ValueRef groups = args.at(13);

const int32_t groups_val = graph.get_int(groups);
const int64_t IC = graph.size_at<int64_t>(-3, packed_int8_input);

const int64_t K_h = graph.get_int_list(kernel_size)->at(0);
const int64_t K_w = graph.get_int_list(kernel_size)->at(1);

// Use im2col path when: non-grouped, input channels multiple of 4, small
// kernel
if (groups_val == 1 && IC % 4 == 0 && K_h <= 3 && K_w <= 3) {
q8ta_conv2d_im2col(graph, args);
} else {
q8ta_conv2d_general(graph, args);
}
q8ta_conv2d_general(graph, args);
}

REGISTER_OPERATORS {
Expand Down
Loading