Skip to content

Add float int32 vulkan shader #17382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SS-JIA merged 1 commit into from
Feb 12, 2026
Merged

Add float int32 vulkan shader #17382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/glsl/view_convert_buffer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,6 @@ view_convert_buffer:
- parameter_values: [uint8, float]
- parameter_values: [uint8, half]
- parameter_values: [uint8, int32]
- parameter_values: [float, int32]
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the float→int32 combo makes view_convert_buffer perform a direct GLSL cast from float to int (OUT_T(t_inp[...]) where OUT_T becomes int). In GLSL, float-to-int conversion is undefined/unspecified for NaNs and for values outside the representable int32 range, which can lead to non-deterministic results. Consider updating the shader logic for this combo to explicitly define behavior (e.g., clamp to int32 min/max before casting and decide how to handle NaNs), so the new variant is robust and matches the expected runtime semantics.

Suggested change
- parameter_values: [float, int32]

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes a runtime crash path (missing shader variant), but there doesn’t appear to be a Vulkan test that exercises float→int32 view/copy conversion. Adding a small unit/integration test that runs a minimal graph/model requiring float→int32 conversion and validates output (and/or that the shader is present in the registry) would help prevent regressions.

Copilot uses AI. Check for mistakes.
shader_variants:
- NAME: view_convert_buffer
Loading