fix : unwaive skipped/special TRT-RTX tests#4156
Open
tp5uiuc wants to merge 2 commits intopytorch:mainfrom
Open
fix : unwaive skipped/special TRT-RTX tests#4156tp5uiuc wants to merge 2 commits intopytorch:mainfrom
tp5uiuc wants to merge 2 commits intopytorch:mainfrom
Conversation
Signed-off-by: tejaswinp <tejaswinp@nvidia.com>
Signed-off-by: tejaswinp <tejaswinp@nvidia.com> fix : tmpl links Signed-off-by: tejaswinp <tejaswinp@nvidia.com>
b9ddf76 to
59ff9ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change unwaives TensorRT-RTX behavior that was previously skipped or hard-blocked:
quantize.py: Dropsvalidate_int8_activation_quantization, which raisedNotImplementedErroron RTX for INT8 activation quantization (.input_quantizer). Removes theENABLED_FEATURESimport and the validation call from the quantize conversion path so RTX can use the same INT8 activation path as other backends (runtime support is acceptable in TRT-RTX 1.4).test_models_export.py: Removes RTX-only pytest.skip for bfloat16 in test_base_int8 and test_base_int8_dynamic_shape, and removes the RTX workaround that disabled *input_quantizer under ModelOpt’s default INT8 config so tests exercise full default INT8 (weights + activations) on RTX. This was enabled in TRT-RTX 1.4test_004_weight_streaming.py: Removes the @unittest.skipIf that skipped a test when tensorrt_rtx was enabled (previously attributed to a cudagraphs issue).Motivation: Align RTX with non-RTX coverage by removing waivers now that the underlying limitations or bugs are considered resolved.
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: