Skip to content

Potential Vulnerability in Cloned Code#4148

Open
navnitan-7 wants to merge 1 commit intopytorch:mainfrom
navnitan-7:fix/cve-2015-9251
Open

Potential Vulnerability in Cloned Code#4148
navnitan-7 wants to merge 1 commit intopytorch:mainfrom
navnitan-7:fix/cve-2015-9251

Conversation

@navnitan-7
Copy link
Copy Markdown

Summary

This change mitigates CVE-2015-9251 behavior in a vendored jQuery clone at docs/v2.10.0/_static/jquery-3.5.1.js.
It mirrors the upstream jQuery security intent to avoid implicit cross-domain script execution during ajax response conversion.

Changes

  • Adds a cross-domain script guard in ajaxConvert(...).
  • Preserves normal conversion flow for other data types.

Impact

This reduces XSS risk from cross-domain ajax responses being interpreted as script implicitly.

References

@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 30, 2026

Hi @navnitan-7!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 30, 2026
@navnitan-7 navnitan-7 closed this Mar 30, 2026
@navnitan-7 navnitan-7 reopened this Mar 30, 2026
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 30, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the cla signed label Mar 30, 2026
@github-actions github-actions bot requested a review from narendasan March 30, 2026 12:58
@navnitan-7
Copy link
Copy Markdown
Author

Requesting review on this security-related patch.

This PR mitigates behavior associated with CVE-2015-9251 in the vendored jQuery file used in documentation assets. The change mirrors the upstream security fix to prevent implicit cross-domain script execution during AJAX response conversion.

Kindly review and let me know if any adjustments are required. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant