Skip to content

Conversation

@zooba
Copy link
Member

@zooba zooba commented Oct 14, 2025

Also adds the test certificate root CA to work around a signing tool limitation

@zooba
Copy link
Member Author

zooba commented Oct 14, 2025

So the signing tool limitation cannot be worked around, and I believe the signing tool fails during the legacy MSI build because it makes multiple attempts at authentication. The next release of the signing tool will let us set %AZURE_TOKEN_CREDENTIALS%=AzureCliCredential and it should only try one approach, but right now they're using an old library without that support. So we're still using a secret token for legacy builds (which unfortunately means it's still just as vulnerable, but at least we aren't accessing it in most other builds now).

@zooba
Copy link
Member Author

zooba commented Oct 14, 2025

Looks like the final test build passed as well, so this is probably the final form of this PR.

@zooba zooba merged commit 17c36be into main Oct 15, 2025
25 checks passed
@zooba zooba deleted the gh-287 branch October 15, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants