Make SPDX IDs stable for non-collisions #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yhg1s
approved these changes
Dec 3, 2024
| @pytest.mark.parametrize( | ||
| ["value", "expected"], | ||
| [ | ||
| ("abc", "abc-ba7816bf"), |
Member
There was a problem hiding this comment.
As far as I can tell this doesn't actually exercise the unhappy hash path, would it make sense to add a collision to this set of parameters? I don't remember if pytest guarantees ordered execution of the test with parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not keeping IDs stable it meant that we weren't matching our source SBOM's IDs, specifically
SPDXRef-PACKAGE-cpython. This keeps the IDs stable unless there is a collision, which can only happen w/ filepaths not package names.