Skip to content

Send Sigstore CLI verification to stdout, not stderr #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 2 commits into from
Nov 20, 2024
Merged

Send Sigstore CLI verification to stdout, not stderr #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07cef9c
Send Sigstore CLI verification to stdout, not stderr
sethmlarson Nov 19, 2024
fe89b7e
lint!
sethmlarson Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,13 +422,23 @@
filename_sigstore = filename + ".sigstore"

if os.path.exists(filename_sigstore):
run_cmd(sigstore_verify_argv + ["--bundle", filename_sigstore, filename])
run_cmd(

Check warning on line 425 in add_to_pydotorg.py

View check run for this annotation

Codecov / codecov/patch

add_to_pydotorg.py#L425 

Added line #L425 was not covered by tests
sigstore_verify_argv + ["--bundle", filename_sigstore, filename],
stderr=subprocess.STDOUT, # Sigstore sends stderr on success.
)

# We use an 'or' here to error out if one of the files is missing.
if os.path.exists(filename_sig) or os.path.exists(filename_crt):
run_cmd(
sigstore_verify_argv
+ ["--certificate", filename_crt, "--signature", filename_sig, filename]
+ [
"--certificate",
filename_crt,
"--signature",
filename_sig,
filename,
],
stderr=subprocess.STDOUT, # Sigstore sends stderr on success.
)


Expand Down