Skip to content

PEP 761: Python 3.14+ discontinues PGP signatures #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethmlarson merged 3 commits into from
Nov 6, 2024
Merged

PEP 761: Python 3.14+ discontinues PGP signatures #189

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5073dab
PEP 761: Python 3.14+ discontinues PGP signatures
hugovk Nov 6, 2024
c79c8ea
Remove --no-gpg argument
hugovk Nov 6, 2024
024f88c
Reference the PEP
hugovk Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions run_release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,11 +1239,6 @@ def _api_key(api_key: str) -> str:
help="Username to be used when authenticating via ssh",
type=str,
)
parser.add_argument(
"--no-gpg",
action="store_true",
help="Skip GPG signing",
)
args = parser.parse_args()

auth_key = args.auth_key or os.getenv("AUTH_INFO")
Expand All @@ -1264,7 +1259,8 @@ def _api_key(api_key: str) -> str:
"This release script is not compatible with the running platform"
)

no_gpg = args.no_gpg
release_tag = release_mod.Tag(args.release)
no_gpg = release_tag.as_tuple() >= (3, 14) # see PEP 761
tasks = [
Task(check_git, "Checking Git is available"),
Task(check_make, "Checking make is available"),
Expand Down Expand Up @@ -1329,10 +1325,10 @@ def _api_key(api_key: str) -> str:
]
automata = ReleaseDriver(
git_repo=args.repo,
release_tag=release_mod.Tag(args.release),
release_tag=release_tag,
api_key=auth_key,
ssh_user=args.ssh_user,
sign_gpg=not args.no_gpg,
sign_gpg=not no_gpg,
tasks=tasks,
)
automata.run()
Expand Down