Allow installing runtimes from a script shebang.#236
Merged
zooba merged 2 commits intopython:mainfrom Dec 11, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to install Python runtimes based on the shebang line found in a script file. This addresses issue #235 by allowing the install command to read a script's shebang (e.g., #! python1.1.exe) and automatically install the corresponding runtime if it's not already present.
Key changes:
- Modified install_command.py to extract runtime specifications from script shebangs when the
--from-scriptflag is used - Replaced global
DOWNLOAD_CACHEwith a per-command cache stored incmd.scratchfor better testability - Added test infrastructure and test cases to verify the new functionality
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/manage/install_command.py | Added logic to parse shebang from scripts and extract runtime tags; replaced global DOWNLOAD_CACHE with cmd.scratch-based caching |
| tests/test_install_command.py | Added InstallCommandTestCmd helper class and test cases for script-based installation |
| tests/conftest.py | Modified assert_log to perform type conversion when comparing logged values with expected values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235