-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 810: Update decisions on with blocks and __dict__ reification #4656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates PEP 810 based on team discussion and feedback: 1. Allow lazy imports inside with blocks - Removed with blocks from syntax restrictions - Added rejected ideas section explaining why restriction was considered 2. __dict__ does not automatically reify lazy imports - Both globals() and __dict__ return raw dictionary without reification - Updated reification section, FAQ, and rejected ideas
pganssle
approved these changes
Oct 13, 2025
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with block stuff LGTM, except for one note.
Yhg1s
reviewed
Oct 13, 2025
Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: T. Wouters <thomas@python.org>
Co-authored-by: T. Wouters <thomas@python.org>
hugovk
reviewed
Oct 13, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
zklaus
pushed a commit
to zklaus/peps
that referenced
this pull request
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates PEP 810 based on team discussion and feedback:
Allow lazy imports inside with blocks
dict does not automatically reify lazy imports
globals()and__dict__return raw dictionary without reification📚 Documentation preview 📚: https://pep-previews--4656.org.readthedocs.build/