Skip to content

PEP 788: Address feedback from discussion round #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZeroIntensity merged 8 commits into from
Oct 14, 2025
Merged

PEP 788: Address feedback from discussion round #4655

ZeroIntensity merged 8 commits into from
Oct 14, 2025

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Oct 13, 2025 •
edited
Loading

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

Rename PyInterpreterLock to PyInterpreterGuard, and also do a bunch of copyediting to improve the clarity of the proposal.

📚 Documentation preview 📚: https://pep-previews--4655.org.readthedocs.build/pep-0788/

@ZeroIntensity
Copy link
Member Author

ZeroIntensity commented Oct 14, 2025

@vstinner Did you want a chance to review, or should I go ahead and merge this?

vstinner
vstinner approved these changes Oct 14, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few minor typos.

@ZeroIntensity @vstinner
Apply suggestions from code review
47434e7 
Co-authored-by: Victor Stinner <vstinner@python.org>
@ZeroIntensity
Copy link
Member Author

ZeroIntensity commented Oct 14, 2025

Thanks!

@ZeroIntensity ZeroIntensity enabled auto-merge (squash) October 14, 2025 11:21
@ZeroIntensity ZeroIntensity merged commit 8fc0771 into python:main Oct 14, 2025
5 checks passed
@vstinner vstinner mentioned this pull request Oct 14, 2025
Closed
@ZeroIntensity ZeroIntensity deleted the pep-788-final-round branch October 17, 2025 02:49
zklaus pushed a commit to zklaus/peps that referenced this pull request Nov 3, 2025
@ZeroIntensity @vstinner @zklaus
PEP 788: Address feedback from discussion round (python#4655)
a674f8f 
* Rename to PyInterpreterGuard.

* Avoid locking terminology.

* Some clarity fixes.

---------

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity @vstinner