Skip to content

PEP-793: Updates based on discussion #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 3 commits into from
Oct 16, 2025
Merged

PEP-793: Updates based on discussion #4651

encukou merged 3 commits into from
Oct 16, 2025

Conversation

@encukou
Copy link
Member

@encukou encukou commented Oct 10, 2025 •
edited by github-actions bot
Loading

  • Remove the spec argument.
  • Add example of token usage. And hopefully make it clearer that it's less important than the size of its section suggests.
  • Add rejected idea: Changing PyModuleDef to not be PyObject
  • Mention that PEP-803 wants to make Py_mod_abi mandatory.

The PEP has an open SC ticket, but they've been warned that details may change.

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4651.org.readthedocs.build/

@encukou
Updates based on discussion
b9cd77a 
- Lose the *spec* argument
- Add *const* to arguments we don't change
- Add a section on tokens
@encukou
Put token use in the main example
364ae9c
@encukou
Fix refcounting in example
cc40c8f
@encukou encukou requested a review from a team as a code owner October 10, 2025 13:57
@encukou encukou merged commit 54cf5eb into python:main Oct 16, 2025
6 checks passed
@encukou encukou deleted the 793-improvements branch October 16, 2025 14:03
zklaus pushed a commit to zklaus/peps that referenced this pull request Nov 3, 2025
@encukou @zklaus
PEP-793: Updates based on discussion (pythonGH-4651)
d2be933 
- Lose the *spec* argument
- Add *const* to arguments we don't change
- Show token use in the example
- Add rejected idea about changing PyModuleDef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@encukou