-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 810: Explicit lazy imports #4622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a CODEOWNERS entry, and fill in the new PEP template.
I'll work on an initial review of the content this evening.
A
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick edit on the initial section before my flight was boarding. Will pick up the review in the next day or two.
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Thanks a lot @willingc |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very exciting to see this! Left some clarifying questions.
Add an example for __lazy_modules__ on first description
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconding other comments, an exciting and very thorough PEP! I've left various comments, let me know if more detail is needed for any of them.
Finally on further formatting banalities, please wrap the text of the PEP to 79 characters at some point before we merge this, per PEPs 1/12.
A
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
I've reflowed the entire thing (hopefully not breaking too much markup, but we'll see when the rebuild finishes.) I think some of your comments are proper discuss material or I'm not quite sure if I've addressed them adequately, so I've left them unresolved. Please resolve/remind as you see fit :) |
|
I'm going to land the PEP because GitHub is crashing for me when addressing comments and suggestions. Additionally I want a final URL because some peeople are finding it confusing. PEP editors: please feel free to open a PR with your suggested changes (thanks a lot for them) if there are any of them missing or please feel free to comment here what we didn't address and we will make sure to update it. Thanks for your understanding and thanks a lot for your excellent work ❤️ |
|
I added a PR with support for highlighting lazy imports in the REPL and I'll be investigating some confusing errors in the REPL I found |
Thanks so much for your enthusiasm and the PR! Just to set expectations: the reference implementation is primarily for evaluating the proposal itself and isn't meant to be a finished product at this stage. If the PEP gets accepted, we'd love your help with the final implementation: that's when we'll be building it out properly. Appreciate your interest in this! |
|
I've reported a bunch of things that I found in the tracker. We can address them after the PEP is accepted. Thanks! |
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4622.org.readthedocs.build/pep-0810/