-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 807: Index support for Trusted Publishing #4597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
@dstufft Please could you confirm your sponsorship? |
Signed-off-by: William Woodruff <william@astral.sh>
|
You can take 807. A |
Signed-off-by: William Woodruff <william@astral.sh>
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @woodruffw. Overall this looks good and I like your approach to standardize the workflow.
Yes. |
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Signed-off-by: William Woodruff <william@astral.sh>
|
Let me know if anything else is needed here for merge! (I'm holding off on the DPO thread until this is live.) |
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few points:
I don't think you say what 'pytp' means anywhere -- presumably 'Python Trusted Publishing'? I assume the acronym form was chosen over spelling out '/trusted-publishing/' for length reasons?
Please remove all the reference targets and/or prefix them with pep807-. You can replace :ref: by just using the section name (e.g. `Section Name`_).
A
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
Yeah, I just made that up 😅 -- I don't actually like it, but I was going to flag it for ideation/bikeshedding on the DPO thread itself. It does indeed stand for "Python Trusted Publishing." |
Signed-off-by: William Woodruff <william@astral.sh>
Signed-off-by: William Woodruff <william@astral.sh>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Thanks @AA-Turner! LMK if it's easier for me to deconflict here (I know it's pretty annoying with the PR-to-an-org-fork workflow...) |
|
@woodruffw please, sorry I hadn't noticed the merge conflicts. A |
|
Done! |
|
Thanks! A |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Pre-PEP thread: https://discuss.python.org/t/pre-pep-trusted-publishing-token-exchange/103067/15
Donald (@dstufft) has graciously agreed to be my sponsor and delegate for this PEP 🙂
Signed-off-by: William Woodruff william@astral.sh
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4597.org.readthedocs.build/pep-0807/