Skip to content

Conversation

@encukou
Copy link
Member

@encukou encukou commented Aug 19, 2025

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template (almost)
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4556.org.readthedocs.build/

@encukou encukou requested a review from a team as a code owner August 19, 2025 15:02
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small comment.

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @encukou. I've made a few readability suggestions.

Copy link
Member Author

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reviews!

Sometimes I have reasons for a particular wording, and copy editing helps make the nuances stand out :)

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@AA-Turner AA-Turner self-requested a review August 21, 2025 22:22
@encukou
Copy link
Member Author

encukou commented Aug 26, 2025

@AA-Turner, are you working on a review?

@AA-Turner
Copy link
Member

Yes, sorry for the delay. I've been unexpectedly busy, should have it finished by Thursday.

A

@encukou
Copy link
Member Author

encukou commented Aug 29, 2025

Please send what you have, or leave it for the next round. I'd like to publish the PEP next week.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay Petr, I've written up the notes I had & done a brief editorial/style pass.

A

Copy link
Member Author

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I do appreciate it, but I worry that we're getting diminishing returns from copy-editing this version. After all, the whole thing might get rewritten after the discussion.

encukou and others added 3 commits September 1, 2025 14:44
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@encukou encukou added the new-pep A new draft PEP submitted for initial review label Sep 5, 2025
@encukou
Copy link
Member Author

encukou commented Sep 5, 2025

I'm not sure about the workflow here: Merging is blocked until all comments must be resolved.
Should I mark them as resolved if you gave a thumbs-up? Or if I don't think I should act on the suggestion?

@AA-Turner
Copy link
Member

I didn't realise the comments hadn't been resolved, sorry. Two replies but non-blocking.

A

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@encukou encukou merged commit 8462643 into python:main Sep 8, 2025
5 checks passed
@encukou encukou deleted the 803 branch September 8, 2025 10:42
@encukou
Copy link
Member Author

encukou commented Sep 8, 2025

Thank you for the thoughtful reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-pep A new draft PEP submitted for initial review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants