-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 803: Stable ABI for Free-Threaded Builds #4556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JelleZijlstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small comment.
willingc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @encukou. I've made a few readability suggestions.
encukou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reviews!
Sometimes I have reasons for a particular wording, and copy editing helps make the nuances stand out :)
Co-authored-by: Carol Willing <carolcode@willingconsulting.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
@AA-Turner, are you working on a review? |
|
Yes, sorry for the delay. I've been unexpectedly busy, should have it finished by Thursday. A |
|
Please send what you have, or leave it for the next round. I'd like to publish the PEP next week. |
AA-Turner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay Petr, I've written up the notes I had & done a brief editorial/style pass.
A
encukou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review! I do appreciate it, but I worry that we're getting diminishing returns from copy-editing this version. After all, the whole thing might get rewritten after the discussion.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
I'm not sure about the workflow here: Merging is blocked until all comments must be resolved. |
|
I didn't realise the comments hadn't been resolved, sorry. Two replies but non-blocking. A |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Thank you for the thoughtful reviews! |
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4556.org.readthedocs.build/