Pep795 take2 #4542
Closed
Pep795 take2 #4542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial * Made pep number an actual number to support building the HTML locally * Made agreed changes to PEP 9999 * Changes following comments from Matt P * Broken RST links fix * MJ comments * All fixed except figures * Fixed rST bugs Fixed broken code example * Adding example * Images * Images * Images * First finished draft * second take on pep * Made a complete pass * Tagged a bunch of things as TODO * Updated some parts according to discussions with Faster CPython team * Apply Matt P's suggestions from code review Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com> * varia * Added note on modularisation * Minor tweaks * Remaining: rebasing + Brandt's comments * Resolved Brand't comments except the figure which is removed for now * Added two rejected alternatives for weak references * MJP's text on rebase on 3.14 Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com> * Mostly done with Matt J's comments * Removed discrepancy in PEP and impl after Matt J additions * Apply suggestions from code review Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com> * Update pep-9999.rst --------- Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com> Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com>
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://pep-previews--4542.org.readthedocs.build/