Skip to content

PEP 784: Mark as Final #4436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gpshead merged 2 commits into from
May 24, 2025
Merged

PEP 784: Mark as Final #4436

gpshead merged 2 commits into from
May 24, 2025

Conversation

@emmatyping
Copy link
Member

@emmatyping emmatyping commented May 24, 2025 •
edited
Loading

  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark as Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

📚 Documentation preview 📚: https://pep-previews--4436.org.readthedocs.build/

@emmatyping emmatyping requested a review from gpshead as a code owner May 24, 2025 04:04
willingc
willingc approved these changes May 24, 2025
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats @emmatyping!

@hugovk
Copy link
Member

hugovk commented May 24, 2025

  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

Please add canonical-doc to link to compression.zstd and/or compression.

@emmatyping
Copy link
Member Author

emmatyping commented May 24, 2025

Please add canonical-doc to link to compression.zstd and/or compression.

Done. I misunderstood the prompt, I thought this only applied to things where there was a living spec like packaging/typing. Thanks for clarifying!

hugovk
hugovk approved these changes May 24, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gpshead gpshead merged commit b8a7cb6 into python:main May 24, 2025
5 checks passed
@emmatyping emmatyping deleted the mark-pep-784-final branch May 24, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

@hugovk hugovk hugovk approved these changes

@willingc willingc willingc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emmatyping @hugovk @gpshead @willingc