Skip to content

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 6, 2025

  • SC/PEP Delegate has formally accepted/rejected the PEP and posted to the Discussions-To thread
  • Pull request title in appropriate format (PEP 123: Mark as Accepted)
  • Status changed to Accepted/Rejected
  • Resolution field points directly to SC/PEP Delegate official acceptance/rejected post, including the date (e.g. `01-Jan-2000 <https://discuss.python.org/t/12345/100>`__)
  • Acceptance/rejection notice added, if the SC/PEP delegate had major conditions or comments
  • Discussions-To, Post-History and Python-Version up to date

cc @warsaw


📚 Documentation preview 📚: https://pep-previews--4406.org.readthedocs.build/

@h-vetinari
Copy link

Congratulations on the acceptance of the PEP! 🥳

While reading again I noticed a small issue:

peps/peps/pep-0749.rst

Lines 878 to 880 in a9f1b15

See `python/cpython#130907`__ for implementation.
__ https://github.com/python/cpython/issue/130907

For one, that link is not working (would need to be /issues/ not /issue/), but more importantly, that issue does not actually discuss the implementation, or rather: the actual implementation ended up not doing the behaviour change implied by the write-up in the issue, but rather kept 3.13 behaviour.

@JelleZijlstra
Copy link
Member Author

Good catch, I'll change the link to the PR with what I ended up implementing.

Comment on lines 878 to 879
is set only when module execution is complete. This is obviously
unintuitive.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perhaps not important anymore now that the PEP is accepted, but you might want to change this sentence, given that the "obviously unintuitive" behaviour is now what PEP 749 implements.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not what's currently implemented.

@JelleZijlstra JelleZijlstra merged commit db044b6 into python:main May 6, 2025
5 checks passed
hugovk pushed a commit to hugovk/peps that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants