PEP 728: Address feedback from Carl #4393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carljm
approved these changes
Apr 29, 2025
Member
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Thank you! I was planning to do this, but clearly hadn't gotten to it yet. This update looks great to me, and addresses all of my comments. Just one comment inline on something that still doesn't quite look right to me.
erictraut
reviewed
Apr 29, 2025
rchen152
approved these changes
Apr 29, 2025
Contributor
rchen152
left a comment
rchen152
left a comment
There was a problem hiding this comment.
LGTM (assuming the review comments are addressed)
Contributor
Author
|
Thanks for the review! Pushed an update. Left a conversation open to confirm if the edit makes sense. |
carljm
approved these changes
Apr 30, 2025
Member
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
This looks good to me. We've had a couple days for reviews, I think I will go ahead and merge.
carljm
reviewed
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion:
https://discuss.python.org/t/pep-728-typeddict-with-typed-extra-items/45443/153
This mainly clarifies indexed accesses and assignments with arbitrary str keys.
cc @carljm :
Let me know if there is anything else you have in mind!
PEP 123: Summary of changes)📚 Documentation preview 📚: https://pep-previews--4393.org.readthedocs.build/