PEP 785: rename method, and a rejected idea #4376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
approved these changes
Apr 15, 2025
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
probably also worth recording the flat_exceptions name in a Rejected Ideas section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brett Canon observed:
and on reflection I agreed that this made sense, renaming the method to
.leaf_exceptions()to match terminology from PEP-654. If this PEP is accepted, I plan to check for appropriate places to introduce the term to the exception-group tutorial and reference documentation.Updating my GitHub search for existing uses of this name still finds zero hits. Interestingly, python-trio/exceptiongroup#13 proposed a
leaf_exceptions()helper for a precursor toExceptionGroup; I've added a footnote with some of that history.