-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
PEP 787: Safer subprocess usage using t-strings #4368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ncoghlan could you confirm that you're sponsoring this PEP? |
|
Yep, I'm a co-author, as the updated PEP is derived from the material we had on this topic in PEP 501 (just reworked by @nhumrich to be cite PEP 750 as the foundation - the two PEPs ended up close enough together that the switch didn't actually change the overall design concept) |
ncoghlan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assorted inline comments for suggestions, but nothing that I consider merge blocking.
The main themes behind the suggestions are:
- placing more emphasis on the improved ergonomics of the
shell=Falseinvocations - being more consistent in noting the limitations on the non-POSIX system shell support
|
I believe I have resolved all requested changes as pertaining to the document itself. There are some lingering questions that are not resolved, that have more to do with the viability of the PEP getting accepted rather than the contents of the PEP itself. I went ahead and resolved those so that we can merge, and those conversations can happen in a more public venue where the community can all opine. |
|
Thank you for the PEP, merged! Please open the discussion thread then open a quick PR to add it to the |
Basic requirements (all PEP Types)
pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) andPEPheaderAuthororSponsor, and formally confirmed their approvalAuthor,Status(Draft),TypeandCreatedheaders filled out correctlyPEP-Delegate,Topic,RequiresandReplacesheaders completed if appropriate.github/CODEOWNERSfor the PEPStandards Track requirements
Python-Versionset to valid (pre-beta) future Python version, if relevantDiscussions-ToandPost-History📚 Documentation preview 📚: https://pep-previews--4368.org.readthedocs.build/