Skip to content

Conversation

@nhumrich
Copy link
Contributor

@nhumrich nhumrich commented Apr 13, 2025

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History

📚 Documentation preview 📚: https://pep-previews--4368.org.readthedocs.build/

@nhumrich nhumrich requested a review from a team as a code owner April 13, 2025 04:41
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 13, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@JelleZijlstra
Copy link
Member

@ncoghlan could you confirm that you're sponsoring this PEP?

@ncoghlan
Copy link
Contributor

Yep, I'm a co-author, as the updated PEP is derived from the material we had on this topic in PEP 501 (just reworked by @nhumrich to be cite PEP 750 as the foundation - the two PEPs ended up close enough together that the switch didn't actually change the overall design concept)

Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assorted inline comments for suggestions, but nothing that I consider merge blocking.

The main themes behind the suggestions are:

  • placing more emphasis on the improved ergonomics of the shell=False invocations
  • being more consistent in noting the limitations on the non-POSIX system shell support

@nhumrich
Copy link
Contributor Author

I believe I have resolved all requested changes as pertaining to the document itself. There are some lingering questions that are not resolved, that have more to do with the viability of the PEP getting accepted rather than the contents of the PEP itself. I went ahead and resolved those so that we can merge, and those conversations can happen in a more public venue where the community can all opine.

@hugovk hugovk merged commit a7f7265 into python:main Apr 14, 2025
5 checks passed
@hugovk
Copy link
Member

hugovk commented Apr 14, 2025

Thank you for the PEP, merged!

Please open the discussion thread then open a quick PR to add it to the Discussions-To and Post-History fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants