Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Apr 9, 2025

Two little things I noticed when I came across @hugovk 's recent PR #4359.


📚 Documentation preview 📚: https://pep-previews--4360.org.readthedocs.build/

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this PR is necessary and adds a bit of churn. I'm okay with removing the first comment but I would leave the second one as is. The suggested change in the second comment implies that there is a pep-0778.rst file where the dots are a better indicator of a skipped number.

@StanFromIreland
Copy link
Member Author

The second one is quite common (183 cases) for example:

peps/.github/CODEOWNERS

Lines 688 to 691 in 02f73b5

# peps/pep-3109.rst
# peps/pep-3110.rst
# peps/pep-3111.rst
# peps/pep-3112.rst

peps/.github/CODEOWNERS

Lines 548 to 550 in 02f73b5

peps/pep-0665.rst @brettcannon
# peps/pep-0666.rst
peps/pep-0667.rst @markshannon

@willingc
Copy link
Contributor

@StanFromIreland Both forms are in the existing CODEOWNERS file. I was stating my view of why this PR seems unnecessary to me.

@StanFromIreland
Copy link
Member Author

I see, I will close it then.

@willingc
Copy link
Contributor

@StanFromIreland Thanks. I encourage you to tackle some of the open documentation issues (or others) on the cpython repo and then work your way to the peps repo after you get a feel for the development cadence. Feel free to ping me for review.

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Apr 10, 2025

For cpython I have ~20 open pr's awaiting review... (mostly datetime and gettext stuff, unfortunately Paul is quite busy) Recently I have been trying to not grow that number so I've stopped sending them as frequently. I'll be opening a pr here updating my pep (775) once we decide on how to go forward, in a few months, however, as my co-author is temporarily unavailable, but I can ping you then if you wish.

@StanFromIreland
Copy link
Member Author

@willingc A docs pr I opened recently if you are still interested #132568 :-)

@StanFromIreland StanFromIreland deleted the patch-2 branch April 16, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants