-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Clean up CODEOWNDERS #4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CODEOWNDERS #4360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this PR is necessary and adds a bit of churn. I'm okay with removing the first comment but I would leave the second one as is. The suggested change in the second comment implies that there is a pep-0778.rst file where the dots are a better indicator of a skipped number.
|
@StanFromIreland Both forms are in the existing CODEOWNERS file. I was stating my view of why this PR seems unnecessary to me. |
|
I see, I will close it then. |
|
@StanFromIreland Thanks. I encourage you to tackle some of the open documentation issues (or others) on the cpython repo and then work your way to the peps repo after you get a feel for the development cadence. Feel free to ping me for review. |
|
For cpython I have ~20 open pr's awaiting review... (mostly datetime and gettext stuff, unfortunately Paul is quite busy) Recently I have been trying to not grow that number so I've stopped sending them as frequently. I'll be opening a pr here updating my pep (775) once we decide on how to go forward, in a few months, however, as my co-author is temporarily unavailable, but I can ping you then if you wish. |
|
@willingc A docs pr I opened recently if you are still interested #132568 :-) |
Two little things I noticed when I came across @hugovk 's recent PR #4359.
📚 Documentation preview 📚: https://pep-previews--4360.org.readthedocs.build/