PEP 776: Address some of pfmoore's comments #4310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to address most of pfmoore's comments here: https://discuss.python.org/t/pep-776-emscripten-support/84996/11 * Clarify that we are speaking of _platform_ tags. * List some examples of full tags that are Pyodide-compatible * Include code to generate compatible tag list * Reference PR to add this code to pypa/packaging and specify that it will be merged. * Add section about dependency specifier markers * Add section on trove classifier * Add note that adding platform tags should have no backwards compatibility implications * Add link to Pyodide's documentation on building, testing, and ci for package maintainers
hoodmane
changed the title
pfmoore
reviewed
Mar 19, 2025
Contributor
Author
hugovk
approved these changes
Mar 27, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Contributor
Author
|
Thanks @hugovk! |
Member
|
And thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address most of @pfmoore's comments here: https://discuss.python.org/t/pep-776-emscripten-support/84996/11
📚 Documentation preview 📚: https://pep-previews--4310.org.readthedocs.build/